ZMtools Package -- Feature Log


Template for each suggested enhancement::

==================================================================

EnhancementNumber:  Enhancement Name				

Statement of suggested enhancement				<date>
----------------------------------
	version x.y
	*
	*
	*
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
	<if needed>
Technical Information					
---------------------
	circumstances
	rsik assessment
	*
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Decision
--------
	*
	* (or technical problems)
	*
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
	<if decision is to make the enhancement>
Plans and Priority
------------------
	*
	*
	*
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Status of implementation
-------------------------
	*
	* (in long-running problems might need more than one)
	*
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Enhancement Done						<date>
----------------
	version x.z

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Location of Documentation
-------------------------

==================================================================

----- Original Message -----
From: "Liz Sexton-Kennedy" <sexton@b0nd18.fnal.gov>
To: <zoom-support@fnal.gov>
Cc: <kennedy@fnal.gov>
Sent: Monday, April 22, 2002 5:10 PM
Subject: request from a user


>         We have a user that wants to add two timers.  He proposes adding
the
> following:
>
> 119 fcdflnx3> cvs diff ZMtools/ZMtools/ZMtimer.h
> Index: ZMtools/ZMtools/ZMtimer.h
> ===================================================================
> RCS file: /usr/people/cvsuser/repository/ZMtools/ZMtools/ZMtimer.h,v
> retrieving revision 1.10
> diff -r1.10 ZMtimer.h
> 353a354,356
> >   //  -----  operator:
> >   ZMdualTimer& operator+=( ZMdualTimer const & t );
> >
> 120 fcdflnx3> cvs diff ZMtools/src/ZM
> ZMtime_t.cc  ZMtimer.cc
> 120 fcdflnx3> cvs diff ZMtools/src/ZMtimer.cc
> Index: ZMtools/src/ZMtimer.cc
> ===================================================================
> RCS file: /usr/people/cvsuser/repository/ZMtools/src/ZMtimer.cc,v
> retrieving revision 1.20
> diff -r1.20 ZMtimer.cc
> 369a370
> >
> 435d435
> <
> 436a437,461
> >
> > ZMdualTimer&  ZMdualTimer::operator+=( ZMdualTimer const & t )  {
> >
> >   ZMcpuTimer::nIntervals_ += t.ZMcpuTimer::nIntervals();
> >   if (t.ZMcpuTimer::max() > ZMcpuTimer::max_ )
> >     ZMcpuTimer::max_ = t.ZMcpuTimer::max();
> >   if (t.ZMcpuTimer::min() < ZMcpuTimer::min_ )
> >     ZMcpuTimer::min_ = t.ZMcpuTimer::min();
> >   ZMcpuTimer::sum_ += t.ZMcpuTimer::sum();
> >   ZMcpuTimer::sumSq_ += t.ZMcpuTimer::sumSq();
> >   ZMcpuTimer::elapsed_ += t.ZMcpuTimer::elapsedTime();
> >
> >   ZMclkTimer::nIntervals_ += t.ZMclkTimer::nIntervals();
> >   if (t.ZMclkTimer::max() > ZMclkTimer::max_ )
> >     ZMclkTimer::max_ = t.ZMclkTimer::max();
> >   if (t.ZMclkTimer::min() < ZMclkTimer::min_ )
> >     ZMclkTimer::min_ = t.ZMclkTimer::min();
> >   ZMclkTimer::sum_ += t.ZMclkTimer::sum();
> >   ZMclkTimer::sumSq_ += t.ZMclkTimer::sumSq();
> >   ZMclkTimer::elapsed_ += t.ZMclkTimer::elapsedTime();
> >
> >   return  *this;
> >
> > }  // ZMtmStats::operator+=()
> >
>
>         Does anyone have any objections?  Is so can you send them to
> ksmcf@fnal.gov and cc them to me and Rob?
>
> Thanks, Liz


I am out of the country at the moment, but have taken a quick look at this
proposal.  It is certainly possible to add this functionality, but I would
recommend it be implemented in a more generic fashion: as proposed, the
extension is limited to one kind of ZMtimer, namely ZMdualTimer, and it may
as well be done for all ZMtimers, since there's not that much more work
involved.  Assuming Mark (Fischler) agrees and the time frame is acceptable,
I can probably begin work on this soon after my return to the office next
week.

    - WEB


Request approved by Mark Fischler 29 Apr 2002
Analysis, draft implementation ... 3   hours
Detailed implementation .......... 2   hours
Testing .......................... 1.5 hours
Documentation updates ............ 0.5 hour
Checkin:  2 May 2002